[
https://issues.apache.org/jira/browse/MAPREDUCE-3873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263322#comment-13263322
]
xieguiming commented on MAPREDUCE-3873:
---------------------------------------
The modified function:
public boolean isValidNode(String hostName) {
synchronized (hostsReader) {
Set<String> hostsList = hostsReader.getHosts();
Set<String> excludeList = hostsReader.getExcludedHosts();
｛color:red｝
String ip = NetUtils.normalizeHostName(hostName);
{color}
return (hostsList.isEmpty() || hostsList.contains(hostName) || hostsList
.contains(ip))
&& !(excludeList.contains(hostName) || excludeList.contains(ip));
}
}
and the function NetUtils.normalizeHostName(hostName) can not be mocked.
So, I think this patch do not need provide the unit testcase.
> Nodemanager is not getting decommisioned if the absolute ip is given in
> exclude file.
> -------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-3873
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3873
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2, nodemanager
> Affects Versions: 0.23.0
> Reporter: Nishan Shetty
> Priority: Minor
> Attachments: MAPREDUCE-3873.patch
>
>
> Configure absolute ip in "yarn.resourcemanager.nodes.exclude-path" and try to
> decommission the node.
> It is not getting decommisioned.But if the hostname is given, decommissioning
> is happening.
> I have also given the ip-host mapping of each machine in /etc/hosts.(i,e in
> every machine the other machines ip-host mapping is specified).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
