[
https://issues.apache.org/jira/browse/MAPREDUCE-4204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13263844#comment-13263844
]
Bikas Saha commented on MAPREDUCE-4204:
---------------------------------------
I am not quite sure about replacing ResourceCalculatorProcessTree with
ResourceCalculatorPlugin. Its not clear that they are one and the same. Each
seems to have different use cases in the code. If you feel strongly about it
then please open a separate jira to merge them and let the committers give
guidance on that. Lets not merge 2 steps of refactoring in 1 jira.
isAvailable() is needed because this functionality is not available for every
OS but MapReduce could be used without this on them. What I could do is assert
in the factory getter that isAvailable is true with a doc note telling
developers to always check isAvailable before trying to create the object.
There is an additional isAvailable on ProcfsBasedProcessTree that I dont like
but I have to leave it there because its TestProcfsBasedProcessTree checks for
that before running - ie it checks if ProcfsBasedProcessTree is supported
before trying to test it.
I cannot change anything around ContainerMemory* because this branch is derived
from Hadoop 1.0 for windows port work.
A key criteria behind the changes in this branch is to make merging back into
mainline as smooth as possible. So we dont want to change the class hierarchy
and names too much.
> Refactor ProcfsBasedProcessTree to make the resource collection object
> pluggable
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4204
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4204
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: MAPREDUCE-4204.patch
>
>
> Making it a pluggable interface will allow replacing the procfs based
> implementation with ones for other platforms.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
