[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271812#comment-13271812
 ] 

Thomas Graves commented on MAPREDUCE-3543:
------------------------------------------

output of testpatch with this small patch with spacing change on top of this 
patch - after a bit of hackery to have test-patch ignore checkedout files

-1 overall.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.
    -1 findbugs.  The patch appears to introduce 11 new Findbugs (version 
1.3.9) warnings.
    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.
                
> Mavenize Gridmix.
> -----------------
>
>                 Key: MAPREDUCE-3543
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3543
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>            Reporter: Mahadev konar
>            Assignee: Thomas Graves
>            Priority: Critical
>         Attachments: MAPREDUCE-3543v1.patch, MAPREDUCE-3543v1.sh, 
> MAPREDUCE-3543v2.patch, MAPREDUCE-3543v2.sh, MAPREDUCE-3543v3.patch, 
> MAPREDUCE-3543v3.sh
>
>
> Gridmix codebase still resides in src/contrib and needs to be compiled via 
> ant. We should move it to maven.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to