[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13278838#comment-13278838
 ] 

Hadoop QA commented on MAPREDUCE-4234:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12528056/MAPREDUCE-4234.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test 
files.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    -1 javadoc.  The javadoc tool appears to have generated 2 warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed unit tests in 
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2394//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2394//console

This message is automatically generated.
                
> SortValidator.java is incompatible with multi-user or parallel use (due to a 
> /tmp file with static name)
> --------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4234
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4234
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: examples
>    Affects Versions: 0.23.3, trunk
>            Reporter: Randy Clayton
>            Priority: Minor
>         Attachments: MAPREDUCE-4234.patch
>
>
> The SortValidator.java file checkRecords method creates a file in the 
> /tmp/sortvalidator directory using a static filename. This can result in 
> failures due to name collisions when the 
> hadoop-mapreduce-client-jobclient-*-tests jar is used by more than one task 
> or one user simultaneously. We use this jar when testing compression codecs 
> and after we started running tests in parallel (four at a time to reduce 
> overall test time) we started experiencing random test failures due to name 
> collisions. Creating a random or unique per thread filename may resolve this 
> issue. We have developed a change to introduce per use unique file names. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to