[
https://issues.apache.org/jira/browse/MAPREDUCE-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13279880#comment-13279880
]
Hadoop QA commented on MAPREDUCE-4274:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12528357/mapreduce-4274.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 javadoc. The javadoc tool appears to have generated 2 warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2402//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2402//console
This message is automatically generated.
> MapOutputBuffer should use native byte order for kvmeta
> -------------------------------------------------------
>
> Key: MAPREDUCE-4274
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4274
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: performance, task
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Priority: Minor
> Attachments: mapreduce-4274.txt
>
>
> I don't have a benchmark to support this, but this should give a small CPU
> improvement on the map output buffer: currently, we create {{kvmeta}} as
> {{ByteBuffer.wrap(kvbuffer).asIntBuffer()}}. According to the javadocs, the
> resulting int buffer will inherit its byte order from the ByteBuffer it comes
> from, and the byte buffer defaults to BIG_ENDIAN. Thus, all of our int access
> to/from the buffer will require byte-swapping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
