[
https://issues.apache.org/jira/browse/MAPREDUCE-3193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285540#comment-13285540
]
Devaraj K commented on MAPREDUCE-3193:
--------------------------------------
Thanks Harsh for looking into the patch. Thanks a lot for your time.
{quote}
Given that both APIs are now supported, do we really need the deprecation? Will
the new name apply to both? Are other properties handled in the same way today?
For example I see in old API the following reuse:
{code:xml}
public static final String NUM_INPUT_FILES =
org.apache.hadoop.mapreduce.lib.input.FileInputFormat.NUM_INPUT_FILES;
{code}
While this patch does not change similar things in mapred.lib even after
deprecation marker. Can this be done here too?
{quote}
The deprecation is still needed. I should use the new name reuse in the old api
as it is done for other properties. I will update in the next patch.
bq. Can the test not be done with just LFS? We can avoid a dependency if it can
be done. Similarly a LJRunner test would be great too, if alright - instead of
an MR cluster.
I don't see any problem of having the test cases this way other than adding the
dependency. I feel would be good to have this test case with MiniDFSCluster.
bq. The last part can still be bettered I think. (Nit: Its not reading
recursively, just listing that way.) Perhaps
"mapreduce.input.fileinputformat.input.dir.recursive" is simpler to have?
I thought from the external perspective, this we don't use other than for
reading purpose. Anyway we can change this name to
"mapreduce.input.fileinputformat.input.dir.recursive". I will update in the
next patch.
Please let me if any other nits/suggestions, I will update the patch.
> FileInputFormat doesn't read files recursively in the input path dir
> --------------------------------------------------------------------
>
> Key: MAPREDUCE-3193
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3193
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv1, mrv2
> Affects Versions: 1.0.2, 0.23.2, 2.0.0-alpha, 3.0.0
> Reporter: Ramgopal N
> Assignee: Devaraj K
> Attachments: MAPREDUCE-3193-1.patch, MAPREDUCE-3193-2.patch,
> MAPREDUCE-3193-2.patch, MAPREDUCE-3193.patch, MAPREDUCE-3193.security.patch
>
>
> java.io.FileNotFoundException is thrown,if input file is more than one folder
> level deep and the job is getting failed.
> Example:Input file is /r1/r2/input.txt
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
