[
https://issues.apache.org/jira/browse/MAPREDUCE-4297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285985#comment-13285985
]
Robert Joseph Evans commented on MAPREDUCE-4297:
------------------------------------------------
The patch makes it so truly empty lines are ignored, which is good.
But I have a couple of comments.
# {code}rawUgi.getLength() == 0{code} is no longer needed because it is the
same as {code}rawUgi.toString().equals(""){code}
# I am just a bit conflicted on white space and I would like your opinion on
it. An empty line is ignored but a line with a single space or a tab in it
will result in a user named ' ' or '\t' which seems bad to me. Similarly a line
with white space in front of or after a user name will result in exactly that a
user name with white space in it. Do we want to even try to deal with this or
not?
> Usersmap file in gridmix should not fail on empty lines
> -------------------------------------------------------
>
> Key: MAPREDUCE-4297
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4297
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/gridmix
> Affects Versions: 0.23.1
> Reporter: Ravi Prakash
> Assignee: Ravi Prakash
> Attachments: MAPREDUCE-4297.patch
>
>
> An empty line (e.g. at the end of the file) in the usersmap file will cause
> gridmix to fail. Empty lines should be silently ignored.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
