[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13286290#comment-13286290
 ] 

Harsh J commented on MAPREDUCE-3562:
------------------------------------

bq. From a defensive programming standpoint I would rather see it synchronized 
because it is simple to do, and could potentially prevent an error from 
happening in the future if someone uses the API incorrectly.

Thanks Robert. Agreed on that. Lets also document the old API about when to 
call close() though, I don't see it doing that presently. New API is clear 
about it, however.
                
> Concurrency issues in MultipleOutputs,JobControl,Counters
> ---------------------------------------------------------
>
>                 Key: MAPREDUCE-3562
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3562
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Ravi Teja Ch N V
>            Assignee: Ravi Teja Ch N V
>         Attachments: MAPREDUCE-3562.patch
>
>
> bq.MultipleOutputs 
>   The close of recordwriters should be synchronized. 
>   public void close() throws IOException, InterruptedException { 
>     for (RecordWriter writer : recordWriters.values()) { 
>       writer.close(context); 
> bq.JobControl.java 
>   the getters of the jobs to be synchronized. 
> bq.Counters.java 
>    makeEscapedCompactString to be made synchronized. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to