[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291203#comment-13291203
 ] 

Benoy Antony commented on MAPREDUCE-4318:
-----------------------------------------

Th other option was to use the new scheme of specifying mapred-queues.xml 
containing he queue configuration. I used QueueManagerTestUtils class to 
achieve this. But there are other mapred-queues.xml in the classpath which gets 
picked up before test's mapred-queues.xml with different configuration.

These files seem to be created when I build using eclipse and if I remove those 
mapred-queues.xml, then test passes. So this may be an eclipse created problem. 

The old scheme of defining queues does not use mapred-queues.xml and hence will 
work regardless multiple mapred-queues.xml issues.

Since we are not testing Queue management here, I believe, keeping the 
following line makes the test more reliable.

mr.getJobTrackerConf().set(DeprecatedQueueConfigurationParser.MAPRED_QUEUE_NAMES_KEY,
        "default");


So I recommend to go with the attached patch. Please let me know if there are 
some other ideas.

                
> TestRecoveryManagershould not use raw and deprecated configuration parameters.
> ------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4318
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4318
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 0.22.1
>            Reporter: Konstantin Shvachko
>            Assignee: Benoy Antony
>         Attachments: MAPREDUCE-4318.patch
>
>
> TestRecoveryManager should not use deprecated config keys, and should use 
> constants for the keys where possible.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to