[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294698#comment-13294698
 ] 

Shrinivas Joshi commented on MAPREDUCE-2374:
--------------------------------------------

Hi Todd,

I spent some time looking in to this. I have a query regarding this. Is there 
any particular reason why a call to rawFs.setPermission method (of 
DefaultTaskController class) is made when it is already performed by 
writeCommand method (of TaskController class)? 

By commenting out the call to rawFs.setPermission method I have not seen these 
errors occurring in my testing. I am in process of additional testing. It may 
not be the ideal solution for this issue, however, it does seem to address it 
to a great extent. If you think there is value in this change then let me know, 
I can create the 1-line patch and run unit tests before submitting it.
                
> Should not use PrintWriter to write taskjvm.sh
> ----------------------------------------------
>
>                 Key: MAPREDUCE-2374
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2374
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>             Fix For: 0.22.1
>
>         Attachments: mapreduce-2374-on-20sec.txt
>
>
> Our use of PrintWriter in TaskController.writeCommand is unsafe, since that 
> class swallows all IO exceptions. We're not currently checking for errors, 
> which I'm seeing result in occasional task failures with the message "Text 
> file busy" - assumedly because the close() call is failing silently for some 
> reason.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to