[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396968#comment-13396968
 ] 

Andrew Ferguson commented on MAPREDUCE-4351:
--------------------------------------------

One point I would like feedback on: ContainerManagerImpl's 
getContainersMonitor() is only used in NodeManager's init() as part of the call 
to createWebServer() --- but with this patch, the ContainersMonitor is now 
created locally and passed to the ContainerManager in NodeManager's init().   
Does it make sense to remove this function?

thanks!
                
> Make ContainersMonitor pluggable
> --------------------------------
>
>                 Key: MAPREDUCE-4351
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4351
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: mrv2, nodemanager
>            Reporter: Andrew Ferguson
>            Assignee: Andrew Ferguson
>         Attachments: MAPREDUCE-4351-v1.patch, MAPREDUCE-4351-v2.patch
>
>
> Make the existing ContainersManager pluggable, just as the ContainerExecutor 
> is currently. This will allow us to add container resource enforcement using 
> other techniques (such as cgroups) in an extensible fashion.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to