[
https://issues.apache.org/jira/browse/MAPREDUCE-4351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397801#comment-13397801
]
Andrew Ferguson commented on MAPREDUCE-4351:
--------------------------------------------
Hi Robert,
Thanks for looking at the patch.
bq. I am a bit confused as to why the creation of the ContainersMonitor was
moved from ContainerManagerImpl to NodeManager. The NodeManager does not appear
to have any need for it.
When I put loading ContainersMonitor into ContainerManagerImpl, a number of
tests failed. It seemed to want to be added as a service before
ContainerManagerImpl was created, but I don't have a full understanding of the
services and how they relate, so this may be have been the wrong move. This
way, it also matches the way ContainerExecutor is loaded, or how other services
such as the NodeStatusUpdater are started.
bq. I would also like to see some more documentation about how a
ContainersMonitor is supposed to behave. The only API in there is setup. It
would be nice to be able to document what events a ContaiersMonitor is expected
to handle (START_MONITORING_CONTAINER, STOP_MONITORING_CONTAINER) and how it
may optionally stop a misbehaving container ContainerKillEvent.
Great point, thanks. I will add documentation.
Andrew
> Make ContainersMonitor pluggable
> --------------------------------
>
> Key: MAPREDUCE-4351
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4351
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: mrv2, nodemanager
> Reporter: Andrew Ferguson
> Assignee: Andrew Ferguson
> Attachments: MAPREDUCE-4351-v1.patch, MAPREDUCE-4351-v2.patch,
> MAPREDUCE-4351-v3.patch, MAPREDUCE-4351-v4.patch, MAPREDUCE-4351-v4.patch
>
>
> Make the existing ContainersManager pluggable, just as the ContainerExecutor
> is currently. This will allow us to add container resource enforcement using
> other techniques (such as cgroups) in an extensible fashion.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
