[
https://issues.apache.org/jira/browse/MAPREDUCE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13402268#comment-13402268
]
Robert Joseph Evans commented on MAPREDUCE-4371:
------------------------------------------------
Just a few comments about the patch.
# the new file needs an apache license comment at the top.
# It would be nice to have a comment in the test about what the test class is
intended to cover.
# The test looks like it is passing, but without any exceptions ever being
caught in the test. The run method catches all exceptions and then kills all
of the jobs. This is because run is intended to potentially be called on its
own thread. Please instead verify that all of the jobs are marked as failed at
the end.
# Inside the patch itself it looks like there are a few places where the
formatting is off. We use 2 spaces for indentation and try to wrap the lines at
under 80 characters.
Other then that it looks good. Also a bit of process in when you upload a
patch please mark the box indicating that it is intended for inclusion in
Apache, also please then hit the submit patch button. This will trigger
Jenkins to try and test the patch against trunk. I am going to hit submit
patch for you, but the checkbox you have to do because it is your code and your
copyright.
> Check for cyclic dependencies in Jobcontrol job DAG
> ---------------------------------------------------
>
> Key: MAPREDUCE-4371
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4371
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv1
> Affects Versions: 3.0.0
> Reporter: madhukara phatak
> Attachments: MAPREDUCE-4371.patch
>
>
> In current implementation of JobControl, whenever there is a cyclic
> dependency between the jobs it throws a Stack overflow exception. This jira
> adds a cyclic check to jobcontrol.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
