[
https://issues.apache.org/jira/browse/MAPREDUCE-4369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13403674#comment-13403674
]
Ivan Mitic commented on MAPREDUCE-4369:
---------------------------------------
Thanks Bikas, change looks much better.
I have two additional questions:
1. I see that you still kept the setProcessPid() separate. Is there a reason
for going with this model instead of passing it as part of
{{ResourceCalculatorPlugin.getResourceCalculatorPlugin()}}?
2. In Task.java, you now initialize {{resourceCalculator}} to {{null}} if
{{jvmContext}} is {{null}}. Before your original change for MAPREDUCE-4203, we
would have the {{resourceCalculator}} with {{System.getenv("JVM_PID")}} as the
{{processPid}}. Is there a scenario where the old behavior is desired?
> Fix streaming job failures with WindowsResourceCalculatorPlugin
> ---------------------------------------------------------------
>
> Key: MAPREDUCE-4369
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4369
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Bikas Saha
> Assignee: Bikas Saha
> Attachments: MAPREDUCE-4369.branch-1-win.1.patch,
> MAPREDUCE-4369.branch-1-win.2.patch
>
>
> Some streaming jobs use local mode job runs that do not start tasks trackers.
> In these cases, the jvm context is not setup and hence local mode execution
> causes the code to crash.
> Fix is to not not use ResourceCalculatorPlugin in such cases or make the
> local job run creating dummy jvm contexts. Choosing the first option because
> thats the current implicit behavior in Linux. The ProcfsBasedProcessTree
> (used inside the LinuxResourceCalculatorPlugin) does no real work when the
> process pid is not setup correctly. This is what happens when local job mode
> runs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
