[
https://issues.apache.org/jira/browse/MAPREDUCE-3993?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13409269#comment-13409269
]
Ahmed Radwan commented on MAPREDUCE-3993:
-----------------------------------------
Looks good, thanks Karthik!
Some minor comments:
* The javadoc: "If the underlying stream throws an unchecked exception, it is
re-thrown as an IOException." is inaccurate as the implementation catches any
Throwable (not just unchecked exceptions). There is also a trailing white space
in the javadoc.
* Minor formatting for this same method: move "throws IOException {" in this
signature to the line above.
* The patch unnecessarily shuffles some imports, reformats lines, and creates
additional diffs, see for example the diffs in ReduceTask.java.
> Graceful handling of codec errors during decompression
> ------------------------------------------------------
>
> Key: MAPREDUCE-3993
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-3993
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv1, mrv2
> Affects Versions: 0.23.1, 1.0.2
> Reporter: Todd Lipcon
> Assignee: Karthik Kambatla
> Attachments: MR-3993_branch1.patch, MR-3993_trunk.patch
>
>
> When using a compression codec for intermediate compression, some cases of
> corrupt data can cause the codec to throw exceptions other than IOException
> (eg java.lang.InternalError). This will currently cause the whole reduce task
> to fail, instead of simply treating it like another case of a failed fetch.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
