[
https://issues.apache.org/jira/browse/MAPREDUCE-4395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13411359#comment-13411359
]
Bhallamudi Venkata Siva Kamesh commented on MAPREDUCE-4395:
-----------------------------------------------------------
I *think*, when we pass the DC entries through options like -files -libjars
etc..., and, if there is any exception during URI construction, it will be
thrown right away. However when we pass the same entries either through config
or through programatically, exception during URI construction is ignored and
the corresponding URI value has been set as +null+.
{code:title=StringUtils#stringToURI|borderStyle=solid}
for (int i = 0; i < str.length;i++){
try{
uris[i] = new URI(str[i]);
}catch(URISyntaxException ur){
System.out.println("Exception in specified URI's " +
StringUtils.stringifyException(ur));
//making sure its asssigned to null in case of an error
uris[i] = null;
}
}
{code}
I *think* fix is, throwing an Illegal argument exception, rather than setting
it as +null+.
Any comments?
> Possible NPE at ClientDistributedCacheManager#determineTimestamps
> -----------------------------------------------------------------
>
> Key: MAPREDUCE-4395
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4395
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: distributed-cache, job submission, mrv2
> Affects Versions: 3.0.0
> Reporter: Bhallamudi Venkata Siva Kamesh
> Assignee: Bhallamudi Venkata Siva Kamesh
> Priority: Critical
>
> {code:title=ClientDistributedCacheManager#determineTimestamps|borderStyle=solid}
> URI[] tfiles = DistributedCache.getCacheFiles(job);
> {code}
> It may be possible that tfiles array contains *null* as it's entry, and
> subsequently leads to NPE.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
