[
https://issues.apache.org/jira/browse/MAPREDUCE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413751#comment-13413751
]
Arun C Murthy commented on MAPREDUCE-4422:
------------------------------------------
bq. Or do you just mean modifying the call to be
conf.get(YarnConfiguration.YARN_APPLICATION_CLASSPATH,
DEFAULT_YARN_APPLICATION_CLASSPATH),
Ahmed - yes. Apologies if I wasn't clear, that was what I meant.
bq. which will not make a difference in this case as the default is already
picked if the property is not set.
Ahmed - the point of doing this is essentially documentation. We follow the
convention all over the codebase so that developers quickly grok the flow; and
hence the jira itself.
bq. Configuration.getString uses StringTokenizer to achieve exactly what
String.split will do here. I am not sure if one is more efficient than the
other,
Ahmed - the idea behind adding Configuration.getStrings was to re-use existing
apis rather than hand-craft it for modularity/reuse, not efficiency. As you can
see, we use it in a number of places all over the codebase for similar
scenarios to parse comma-delimited values.
> YARN_APPLICATION_CLASSPATH needs a documented default value in
> YarnConfiguration
> --------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4422
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4422
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: nodemanager
> Affects Versions: 2.0.0-alpha
> Reporter: Arun C Murthy
> Assignee: Ahmed Radwan
> Fix For: 2.0.1-alpha
>
> Attachments: MAPREDUCE-4422.patch, MAPREDUCE-4422_rev2.patch,
> MAPREDUCE-4422_rev3.patch, MAPREDUCE-4422_rev3.patch
>
>
> MAPREDUCE-3505 allowed YARN_APPLICATION_CLASSPATH to be configurable.
> However, we didn't add a default value to YarnConfiguration, as-is the norm.
> Ran into it while investigating MAPREDUCE-4421.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
