[
https://issues.apache.org/jira/browse/MAPREDUCE-4283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13415476#comment-13415476
]
Robert Joseph Evans commented on MAPREDUCE-4283:
------------------------------------------------
I am +1 on this patch, but I am going to wait to check it in until Sid has a
chance to look at it too.
I don't want to kill this patch with minor nits, so I am OK with this going in
as is. If you want to fix it feel free. But LogKey hash and equals are
inconsistent. In hash you handle the case of keyString == null, but in equals
you do not. You will get an NPE if it is null. It should never be null,
because other places will throw NPEs too, so it would be best just to check for
null in the constructor.
> Display tail of aggregated logs by default
> ------------------------------------------
>
> Key: MAPREDUCE-4283
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4283
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: jobhistoryserver, mrv2
> Affects Versions: 0.23.3, 2.1.0-alpha
> Reporter: Jason Lowe
> Assignee: Jason Lowe
> Attachments: MAPREDUCE-4283.patch, MAPREDUCE-4283.patch,
> MAPREDUCE-4283.patch, MAPREDUCE-4283.patch, MAPREDUCE-4283.patch
>
>
> Similar to the manner in which the nodemanager webUI displays container logs,
> it would be very useful if the historyserver showed the trailing 4K or so of
> the aggregated logs with a link to see the full log.
> When debugging issues the relevant errors are usually at the end of the log,
> so showing just the last few K can enable quick diagnosis without waiting for
> what can be many megabytes of log data to download.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
