[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419437#comment-13419437
 ] 

Ryan Hennig commented on MAPREDUCE-4462:
----------------------------------------

When I was browsing this code on the ipad, I did not have tools to jump around 
the code and I misinterpreted the units as MB, since the setResources(int 
memory) call had no comments to specify the measurement unit.  I saw that the 
other scheduler test code makes widespread use of this "* GB" construct, so I 
adopted it for use in the Fair Scheduler code.
                
> Add comments to TestFairScheduler.java
> --------------------------------------
>
>                 Key: MAPREDUCE-4462
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4462
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: scheduler, test
>            Reporter: Ryan Hennig
>            Priority: Minor
>              Labels: comments, test
>             Fix For: 2.1.0-alpha
>
>         Attachments: MAPREDUCE-4462.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> While reading over the unit tests for the Fair Scheduler introduced by 
> MAPREDUCE-3451, I added comments to make the logic of the test easier to grok 
> quickly.  Creating a JIRA as a placeholder to submit this work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to