[
https://issues.apache.org/jira/browse/MAPREDUCE-4452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420133#comment-13420133
]
Junping Du commented on MAPREDUCE-4452:
---------------------------------------
In new v3 patch, separating monitor objects from attributes to get rid of
ML_SYNC_ON_FIELD_TO_GUARD_CHANGING_THAT_FIELD which is due to updating on lock
object. Also, add synchronization to getter/setter of userMaxAppsDefault and
queueMaxAppsDefault to get ride of FindBugs warning.(in fact, it is not
necessary because this is int type and should be finished in one CPU
instruction. However, it is not much overhead as lock level is fine-grained).
> Several Findbugs issues with new FairScheduler in YARN
> ------------------------------------------------------
>
> Key: MAPREDUCE-4452
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4452
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: scheduler
> Affects Versions: 2.1.0-alpha
> Reporter: Junping Du
> Assignee: Junping Du
> Attachments: MAPREDUCE-4452-v1.patch, MAPREDUCE-4452-v2.patch,
> MAPREDUCE-4452-v3.patch, MAPREDUCE-4452-v3.patch, MAPREDUCE-4452.patch
>
>
> The good feature of FairScheduler is added recently to YARN. As recently
> PreCommit test from MAPREDUCE-4309, there are several bugs found by Findbugs
> related to FairScheduler:
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairSchedulerEventLog.shutdown()
> might ignore java.lang.Exception
> Inconsistent synchronization of
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairSchedulerEventLog.logDisabled;
> locked 50% of time
> Inconsistent synchronization of
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.QueueManager.queueMaxAppsDefault;
> locked 50% of time
> Inconsistent synchronization of
> org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.QueueManager.userMaxAppsDefault;
> locked 50% of time
> The details are
> in:https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2612//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html#DE_MIGHT_IGNORE
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
