[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427418#comment-13427418
 ] 

Robert Joseph Evans commented on MAPREDUCE-3223:
------------------------------------------------

I did a quick look through the changes, and the tests pass so I am +1 on the 
change as is.

Are there any JIRAs to deprecate the configs from where they reside in the 
code? 
./hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/server/jobtracker/JTConfig.java
 for example. I know we cannot delete them out just yet, because MRV1 code 
still exists and may be using it, but it would be good to mark all of those 
configs as deprecated. So that we can delete them in trunk once the MRV1 code 
is completely removed.  A separate JIRA is fine for that, which is why I am 
still +1 on the original patch.
                
> Remove MR1 configs from mapred-default.xml
> ------------------------------------------
>
>                 Key: MAPREDUCE-3223
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3223
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: documentation, mrv2
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: mr-3223.txt, mr-3223.txt
>
>
> All of the MRv1 configs are still in mapred-default.xml. This is confusing 
> when trying to make config changes. Since a lot of the input/output format 
> tests still depend on MR1, I'd like to move these to src/test/mapred-site.xml 
> for now, and once that dependency is broken, we can remove them entirely.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to