[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427483#comment-13427483
 ] 

Bikas Saha commented on MAPREDUCE-4275:
---------------------------------------

I am ok with the null pointer check. You are right that there should be a 
single factory getting OS specific resource objects. How about moving the 
procfsbasedprocesstree factory to resourcecalculatorprocesstree for now so that 
the code flow stays similar to what it currently is. Looks like you have some 
ideas for re-organizing this part of the code better. we could handle the 
factory creation and other refactorings etc as part of that change. sounds like 
a plan?
                
> Plugable process tree
> ---------------------
>
>                 Key: MAPREDUCE-4275
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4275
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 3.0.0
>         Environment: FreeBSD 64 bit
>            Reporter: Radim Kolar
>         Attachments: plugable-pstree-1.txt, plugable-pstree-2.txt, 
> plugable-pstree.txt
>
>
> Trunk version of Pluggable process tree. Work based on MAPREDUCE-4204

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to