[
https://issues.apache.org/jira/browse/MAPREDUCE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13427839#comment-13427839
]
Alejandro Abdelnur commented on MAPREDUCE-4488:
-----------------------------------------------
looks good, some minor comments:
* JobInProgress constructors, is there a need to create a JobContext to get the
value of the flag? Why just not do a conf.get() ?
* JobInProgress initSetupCleanupTask(), revert the IF condition and do the
logic within the IF block, then no need for a return call.
* JobInProgress setupComplete(), do an ELSE instead of return call at the end
of the first IF block.
> Port MAPREDUCE-463 (The job setup and cleanup tasks should be optional) to
> branch-1
> -----------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4488
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4488
> Project: Hadoop Map/Reduce
> Issue Type: New Feature
> Components: mrv1, performance
> Affects Versions: 1.0.3
> Reporter: Tom White
> Assignee: Tom White
> Attachments: MAPREDUCE-4488.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
