[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428541#comment-13428541
 ] 

Harsh J commented on MAPREDUCE-4431:
------------------------------------

+1, looks good to me too.

One comment though (just want your thought):

{code}
+            System.out.println("The job " + jobid + " has already been 
killed.");
+            exitCode = -1;
{code}

In case the job was already killed, should we perhaps return 0 exitCode (since 
the kill was (already) successful?
                
> killing already completed job gives ambiguous message as "Killed job <job id>"
> ------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4431
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4431
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Nishan Shetty
>            Assignee: Devaraj K
>            Priority: Minor
>         Attachments: MAPREDUCE-4431-1.patch, MAPREDUCE-4431.patch
>
>
> If we try to kill the already completed job by the following command it gives 
> ambiguous message as "Killed job <job id>"
> ./mapred job -kill <already completed job id>

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to