[
https://issues.apache.org/jira/browse/MAPREDUCE-4296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434587#comment-13434587
]
Jason Lowe commented on MAPREDUCE-4296:
---------------------------------------
Patch looks good overall, some cleanup comments:
* Probably need a release note stating the necessary chmod operations on user
directories under the top-level aggregated log directory
* Speaking of which, is it worth checking the permissions of the user directory
before we try to delete all the application logs underneath it? I'm thinking
of all the exceptions that will be logged periodically if one user's log
directory doesn't have the proper permissions to allow deletion but there are
hundreds of application logs underneath it.
* With all the nested try/catch blocks, it might be easier to read if one or
more of the {{for}} loops were factored out into private methods
* Spelling nits (many are end-user visible and should be cleaned up):
** retain is misspelled in yarn.log-aggregation.retian-seconds
** being is misspelled as beign
** "desabled because retiontion" should be "disabled because retention"
** aggregated misspelled as aggregatied
> remove old aggregated logs
> --------------------------
>
> Key: MAPREDUCE-4296
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4296
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.23.3
> Reporter: Thomas Graves
> Assignee: Robert Joseph Evans
> Attachments: MR-4296.txt
>
>
> Currently the aggregated user logs under NM_REMOTE_APP_LOG_DIR are never
> removed. We should have mechanism to remove them after certain period.
> It might make sense for job history server to remove them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
