[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435199#comment-13435199
 ] 

Daryn Sharp commented on MAPREDUCE-4323:
----------------------------------------

I think the additional {{closeAllForUGI}} needs to be added like this to guard 
against exceptions in the other cleanup operations causing the fs close to be 
skipped.
{code}
} finally {
  try {
    if (exec != null) {
      exec.shutdownNow();
    }
    LocalDirAllocator.removeContext(appCacheDirContextName);
  } finally {
    closeFileSystems(ugi);
  }
}
{code}

You probably want to break out the {{closeAllForUGI}} into {{closeFileSystems}} 
ala the aggregator part of the patch so mocking a test will be easier.
                
> NM leaks filesystems
> --------------------
>
>                 Key: MAPREDUCE-4323
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4323
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 0.23.0, 0.24.0, 2.0.0-alpha
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>            Priority: Critical
>         Attachments: MAPREDUCE-4323.patch, MAPREDUCE-4323.patch
>
>
> The NM is exhausting its fds because it's not closing fs instances when the 
> app is finished.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to