[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Siddharth Seth updated MAPREDUCE-4581:
--------------------------------------

            Priority: Minor  (was: Major)
    Target Version/s: MR-3902
                Tags:   (was: MR-3902)
            Assignee: Tsuyoshi OZAWA

Tsuyoshi, thanks for taking this up.

The patch does not look complete. It should be removing a lot of the code from 
TaskHeartbeatHandler.
Other than that, 1) Two events should be going out - the Diagnostic event from 
the current HeartbeatHandler is missing. 2) Needs some formatting fixes. 
(Formatting guidelines at http://wiki.apache.org/hadoop/HowToContribute)

                
> TaskHeartbeatHandler should extends HeartbeatHandlerBase
> --------------------------------------------------------
>
>                 Key: MAPREDUCE-4581
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4581
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>          Components: applicationmaster
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>            Priority: Minor
>         Attachments: MAPREDUCE-4581.patch
>
>
> TaskHeartbeatHandler extends AbstractService currently, however, this causes 
> code duplication between TaskHeartbeatHandler and HeartbeatHandlerBase. 
> TaskHeartbeatHandler should extends HeartbeatHandlerBase to solve the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to