[
https://issues.apache.org/jira/browse/MAPREDUCE-2786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445427#comment-13445427
]
Konstantin Shvachko commented on MAPREDUCE-2786:
------------------------------------------------
A few review comments. (Unlike Jenkins I could apply your patch)
- createControlFile() uses new compressionClass parameter only to Log it.
You should log compressionClass in run() along with other input parameters,
like bufferSize or baseDir. That should be enough.
- Don't print it in analyzeResult() either. I think it is not the output
parameter but the input.
Even if it was necessary, it should be taken from conf.
- White space changes inside loop in doIO() for WriteMapper and ReadMapper.
Please avoid.
Otherwise it's good and good to go.
> TestDFSIO should also test compression reading/writing from command-line.
> -------------------------------------------------------------------------
>
> Key: MAPREDUCE-2786
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2786
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: benchmarks
> Affects Versions: 2.0.0-alpha
> Reporter: Plamen Jeliazkov
> Priority: Minor
> Labels: newbie
> Fix For: 2.1.0-alpha
>
> Attachments: MAPREDUCE_2786.patch, MAPREDUCE-2786.patch
>
> Original Estimate: 36h
> Remaining Estimate: 36h
>
> I thought it might be beneficial to simply alter the code of TestDFSIO to
> accept any compression codec class and allow testing for compression by a
> command line argument instead of having to change the config file everytime.
> Something like "-compression" would do.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
