[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446326#comment-13446326
 ] 

Siddharth Seth commented on MAPREDUCE-4582:
-------------------------------------------

Thanks for the updated patch. Needs one minor fix - removing entries from 
attemptToLaunchRequestMap needs to happen after the ScheduledRequests.remove 
call.
                
> [MAPREDUCE-3902] ScheduledRequests#remove should remove the elements from 
> mapsHostMapping and mapsRackMapping
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4582
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4582
>             Project: Hadoop Map/Reduce
>          Issue Type: Sub-task
>    Affects Versions: MR-3902
>            Reporter: Tsuyoshi OZAWA
>            Assignee: Tsuyoshi OZAWA
>            Priority: Minor
>         Attachments: MAPREDUCE-4582.2.patch, MAPREDUCE-4582.patch
>
>
> ScheduledRequests#remove only remove the specified TaskAttemptId from "maps".
> It's inefficient, and the method should remove the elements from 
> mapsHostMapping and mapsRackMapping.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to