[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450071#comment-13450071
 ] 

Alejandro Abdelnur commented on MAPREDUCE-4629:
-----------------------------------------------

Karthik,

If DEBUG_MODE is there only for the purposes of reducing the hardcoded cleanup 
time, then I agree we should make this configurable. Default value should be 
the current 'non-debug' max age of 1 month. We should have a consistent 
directory layout regardless of the cleanup time, I'd suggest using 
yyyy/mm/dd-HH-MM, to avoid having a subdir explosion. the cleanup logic should 
be smart enough to look at the necessary granularity in the name. Regarding the 
printing of stack traces, those should be converted to LOG.trace() calls. Make 
sense?
                
> In DEBUG_MODE, JobHistory#directoryTime() returns incorrect time
> ----------------------------------------------------------------
>
>                 Key: MAPREDUCE-4629
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4629
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 1.0.3
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: MR-4629.patch, MR-4629.patch.v1
>
>
> The helper methods in JobHistory - directoryTime() and 
> timestampDirectoryComponent() - adjust the month field for readability (Jan 
> is 0 as per Calendar, 1 for us)
> In DEBUG_MODE, JobHistory uses hour instead of month. However, the adjustment 
> is still applied.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to