[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vinod Kumar Vavilapalli updated MAPREDUCE-4367:
-----------------------------------------------

    Fix Version/s:     (was: trunk)
           Status: Open  (was: Patch Available)

The issue is valid, I see it too. But the patch has lots of problems and can be 
simplified greatly.

Have the following comments regarding the patch:
 -  The patch unnecessarily creates two connections for every client, side 
stepping the ClientCache etc. Overall, you can limit the code changes to 
{{ClientServiceDelegate.getProxy()}}. This method can take in an additional 
parameter {{redirectToJHSIfNeeded}} which can be set to false for job-kill. If 
this parameter is set to true, {{getProxy()}} can simply log a message and 
return a {{NonRunningJob}}
 - We also need to do the same change for {{killTask()}}
 - Also, {{MiniMRYarnCluster}} doesn't need extra APIs like 
stopHistoryServer(), one can simply get a handle to JHS and stop it.
                
> mapred job -kill tries to connect to history server
> ---------------------------------------------------
>
>                 Key: MAPREDUCE-4367
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4367
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: client, mrv2
>    Affects Versions: 0.23.3
>            Reporter: Jason Lowe
>            Assignee: Mayank Bansal
>            Priority: Minor
>         Attachments: MAPREDUCE-4367-trunk-v1.patch, 
> MAPREDUCE-4367-trunk-v2.patch
>
>
> The {{mapred job -kill}} command attempts to connect to the history server, 
> even though it is unrelated to the process of killing a job.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to