[
https://issues.apache.org/jira/browse/MAPREDUCE-4651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455133#comment-13455133
]
Konstantin Shvachko commented on MAPREDUCE-4651:
------------------------------------------------
(1) I did want to make IOMapperBase.getIOStream() abstract, but there are other
tests that are based on IOMapperBase. A dummy implementation of getIOStream()
will avoid changing them.
(2) Do you want me to add spaces or you see unnecessary spaces in my patch?
(3) So you suggest to add comments to @Override specifying the base class,
right? Agreed, should have done that for the new method, will also do it for
doIO().
(4) Sure you can check the instance before casting, but what would you do in
the else clause - throw exception. So one way or another an exception will be
thrown saying the type of stream is not right. And this is sort of an assert,
because it means there is a bug in DFSIO, not user's fault.
(5) Yep, you are right nanoTime() is already in the default constructor. I
believe it wasn't there before.
Thanks for the review. I'll check SLive jira.
> Benchmarking random reads with DFSIO
> ------------------------------------
>
> Key: MAPREDUCE-4651
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4651
> Project: Hadoop Map/Reduce
> Issue Type: New Feature
> Components: benchmarks, test
> Affects Versions: 1.0.0
> Reporter: Konstantin Shvachko
> Assignee: Konstantin Shvachko
> Attachments: randomDFSIO.patch
>
>
> TestDFSIO measures throughput of HDFS write, read, and append operations. It
> will be useful to have an option to use it for benchmarking random reads.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
