[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456065#comment-13456065
 ] 

Thomas Graves commented on MAPREDUCE-4647:
------------------------------------------

Few minor comments.

- Since Pattern is really only implemented for jars but it still handles zip, 
tar.gz, tar we should try to document the behavior better.
- It might be nice to add something like "even though specified as a Pattern" 
to the warning message in unpack in FSDownload.java
                
> We should only unjar jobjar if there is a lib directory in it.
> --------------------------------------------------------------
>
>                 Key: MAPREDUCE-4647
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4647
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>    Affects Versions: 0.23.3
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: MR-4647.txt, MR-4647.txt, MR-4647.txt
>
>
> For backwards compatibility we recently added made is so we would unjar the 
> job.jar and add anything to the classpath in the lib directory of that jar.  
> But this also slows job startup down a lot if the jar is large.  We should 
> only unjar it if actually doing so would add something new to the classpath.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to