[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471905#comment-13471905
 ] 

Alejandro Abdelnur commented on MAPREDUCE-4676:
-----------------------------------------------

CachedHistoryStorage.getFullJob(jobId) should synchronize on fileInfo from 
fileInfo.isDeleted() until loadJob(fileInfo) to avoid a race condition.

I'm not very convinced on modifying methods signature for testing purposes 
only. I'll think about an alternative while you work on the above comment.
                
> Add test for job history cleaner
> --------------------------------
>
>                 Key: MAPREDUCE-4676
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4676
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: jobhistoryserver
>    Affects Versions: 1.0.3, 2.0.1-alpha
>            Reporter: Sandy Ryza
>            Assignee: Sandy Ryza
>         Attachments: MAPREDUCE-4676.patch, MAPREDUCE-4676-trunk.patch
>
>
> Add a test to TestJobHistory that verifies that the HistoryCleaner cleans up 
> the job history

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to