[
https://issues.apache.org/jira/browse/MAPREDUCE-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473411#comment-13473411
]
Alejandro Abdelnur commented on MAPREDUCE-2454:
-----------------------------------------------
Initial feedback on the patch (I'll do a more detailed review):
* Nice work
* patch needs rebase, TestReduceTask.java has been moved to
hadoop-mapreduce-client-jobclient/
* remove introduced & unused imports through out the patch
* reformat lines with over 80 chars through out the patch
I'm not trilled on how we are mixing mapred and mapreduce classes in the APIs
of pluggable sort. But given how the current MR stuff implementation is done, I
don't think it is possible to avoid that without a mayor cleanup/refactoring of
much bigger scope.
One thing would be quite useful, and I'd say a pre-requisite before committing
it, is a performance comparison of terasort with and without the patch; we
shouldn't be introducing a sensible performance penalty.
> Allow external sorter plugin for MR
> -----------------------------------
>
> Key: MAPREDUCE-2454
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2454
> Project: Hadoop Map/Reduce
> Issue Type: New Feature
> Affects Versions: 2.0.0-alpha, 3.0.0, 2.0.2-alpha
> Reporter: Mariappan Asokan
> Assignee: Mariappan Asokan
> Priority: Minor
> Labels: features, performance, plugin, sort
> Attachments: HadoopSortPlugin.pdf, HadoopSortPlugin.pdf,
> KeyValueIterator.java, MapOutputSorterAbstract.java, MapOutputSorter.java,
> mapreduce-2454.patch, mapreduce-2454.patch, mapreduce-2454.patch,
> mapreduce-2454.patch, mapreduce-2454.patch, mapreduce-2454.patch,
> mapreduce-2454.patch, mapreduce-2454.patch, mapreduce-2454.patch,
> mapreduce-2454.patch, mapreduce-2454.patch,
> mr-2454-on-mr-279-build82.patch.gz, MR-2454-trunkPatchPreview.gz,
> ReduceInputSorter.java
>
>
> Define interfaces and some abstract classes in the Hadoop framework to
> facilitate external sorter plugins both on the Map and Reduce sides.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
