[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13502332#comment-13502332
 ] 

Alejandro Abdelnur commented on MAPREDUCE-4703:
-----------------------------------------------

It looks good, a couple of nits:

* remove the javadocs that only says "@throw Exception" in MiniMRClientCluster, 
and keep the explanation of the restart.
* the formatting indentation of the restart() method is funny, you have 6 more 
chars to go before reaching 80 and it would be much easier to read, (also, IMO, 
for 1 or 2 chars, no need to go down if gets ugly to the eye).
                
> Add the ability to start the MiniMRClientCluster using the configurations 
> used before it is being stopped.
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4703
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4703
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2, test
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>         Attachments: MAPREDUCE-4703_branch-1.patch, MAPREDUCE-4703.patch, 
> MAPREDUCE-4703_rev2.patch
>
>
> The objective here is to enable starting back the cluster, after being 
> stopped, using the same configurations/port numbers used before stopping.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to