[
https://issues.apache.org/jira/browse/MAPREDUCE-4840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508366#comment-13508366
]
Harsh J commented on MAPREDUCE-4840:
------------------------------------
Thanks Mostafa!
I actually got a bit confused earlier.
# The Skipping feature does work with the Old API presently, correct? Have you
observed otherwise? MAPREDUCE-1932 was for supporting it in New API.
# The idea is to deprecate the feature, cause it won't be added to the new API
and the concept is to be unsupported, in favor of user-end logic. The patch
removes it directly without giving a deprecation first.
> Delete dead code and deprecate public API related to skipping bad records
> -------------------------------------------------------------------------
>
> Key: MAPREDUCE-4840
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4840
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha
> Reporter: Mostafa Elhemali
> Priority: Minor
> Attachments: MAPREDUCE-4840.patch
>
>
> It looks like the decision was made in MAPREDUCE-1932 to remove support for
> skipping bad records rather than fix it (it doesn't work right now in trunk).
> If that's the case then we should probably delete all the dead code related
> to it and deprecate the public API's for it right?
> Dead code I'm talking about:
> 1. Task class: skipping, skipRanges, writeSkipRecs
> 2. MapTask class: SkippingRecordReader inner class
> 3. ReduceTask class: SkippingReduceValuesIterator inner class
> 4. Tests: TestBadRecords
> Public API:
> 1. SkipBadRecords class
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
