[
https://issues.apache.org/jira/browse/MAPREDUCE-2632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508424#comment-13508424
]
Mostafa Elhemali commented on MAPREDUCE-2632:
---------------------------------------------
A few comments:
1. Stylistic nit-picks: else should be on same line as closing brace, and
should have a space after. And "part=0" needs more space.
2. Can you put a comment (and test) that partitioner can be null if there's
only one reader? One of the nice things about MAPREDUCE-1287 is that it doesn't
even construct the partitioner if it's not needed, so we should help client
code do that as well.
> Avoid calling the partitioner when the numReduceTasks is 1.
> -----------------------------------------------------------
>
> Key: MAPREDUCE-2632
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2632
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: tasktracker
> Affects Versions: 0.23.0
> Reporter: Ravi Teja Ch N V
> Assignee: Ravi Teja Ch N V
> Attachments: MAPREDUCE-2632-1.patch, MAPREDUCE-2632.patch
>
>
> We can avoid the call to the partitioner when the number of reducers is
> 1.This will avoid the unnecessary computations by the partitioner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
