[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511464#comment-13511464
 ] 

Radim Kolar commented on MAPREDUCE-4851:
----------------------------------------

No, partitioner change is backward compatible. This is not. Also i am not 
merging tickets because this will delay review process, which is slow enough 
already. They do not depends on each other.

Use case for cleanup() method is in my case: to disconnect from transaction 
manager, shutdown datagrid, shutdown spring context.
                
> add lifecycle to Comparators
> ----------------------------
>
>                 Key: MAPREDUCE-4851
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4851
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Radim Kolar
>              Labels: mrv2
>
> current mapreduce api is using RawComparator interface in:
> setGroupingComparatorClass
> setSortComparatorClass
> This interface has no lifecycle support. I propose to change that methods to 
> take argument new class implements RawComparator with setup and cleanup 
> methods. 
> This will leave existing code with RawComparator alone, Providing some 
> backward compatibility.
> new class: 
> class SortComparator implements RawComparator

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to