[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karthik Kambatla updated MAPREDUCE-4862:
----------------------------------------

    Description: 
yarn.s.rm.security.DelegationTokenRenewer uses TimerTask/Timer. When such a 
timer task is canceled, already scheduled tasks run to completion. The task 
should check for such cancellation before running. Also, delegationTokens needs 
to be synchronized on all accesses.



  was:
mapreduce.security.token.DelegationTokenRenewal synchronizes on 
removeDelegationToken, but fails to synchronize on addToken, and renewing 
tokens in run().

This inconsistency is exposed by frequent failures of 
TestDelegationTokenRenewal:
{noformat}
Error Message

renew wasn't called as many times as expected expected:<4> but was:<5>
Stacktrace

junit.framework.AssertionFailedError: renew wasn't called as many times as 
expected expected:<4> but was:<5>
        at 
org.apache.hadoop.mapreduce.security.token.TestDelegationTokenRenewal.testDTRenewal(TestDelegationTokenRenewal.java:317)
        at 
org.apache.hadoop.mapreduce.security.token.TestDelegationTokenRenewal.testDTRenewalAfterClose(TestDelegationTokenRenewal.java:338)

{noformat}


    
> Inconsistent synchronization in yarn.server.rm.security.DelegationTokenRenewal
> ------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4862
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4862
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 1.1.1
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>
> yarn.s.rm.security.DelegationTokenRenewer uses TimerTask/Timer. When such a 
> timer task is canceled, already scheduled tasks run to completion. The task 
> should check for such cancellation before running. Also, delegationTokens 
> needs to be synchronized on all accesses.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to