[
https://issues.apache.org/jira/browse/MAPREDUCE-4808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556738#comment-13556738
]
Chris Douglas commented on MAPREDUCE-4808:
------------------------------------------
+1 Looked through it; the latest patch lgtm. Asokan, is that sufficient for
your use cases? Arun?
_Very_ minor, optional nit: {{s/MergeManager/MergeManagerImpl/}} and
{{s/MergeManagerPlugin/MergeManager/}}. There's an argument to be made for
doing the same with the {{ShuffleScheduler}} while we're at it, but neither of
these are blocking, IMO.
> Refactor MapOutput and MergeManager to facilitate reuse by Shuffle
> implementations
> ----------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4808
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4808
> Project: Hadoop Map/Reduce
> Issue Type: New Feature
> Reporter: Arun C Murthy
> Assignee: Mariappan Asokan
> Attachments: COMBO-mapreduce-4809-4812-4808.patch,
> mapreduce-4808.patch, mapreduce-4808.patch, mapreduce-4808.patch,
> mapreduce-4808.patch, mapreduce-4808.patch, mapreduce-4808.patch,
> mapreduce-4808.patch, MergeManagerPlugin.pdf, MR-4808.patch
>
>
> Now that Shuffle is pluggable (MAPREDUCE-4049), it would be convenient for
> alternate implementations to be able to reuse portions of the default
> implementation.
> This would come with the strong caveat that these classes are LimitedPrivate
> and Unstable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
