[
https://issues.apache.org/jira/browse/MAPREDUCE-4808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Douglas updated MAPREDUCE-4808:
-------------------------------------
Attachment: M4808-0.patch
I'd argue:
# {{sed}} is not brain surgery and these issues will likely be backported to
branch-2 anyway
# Taking the good names for interfaces, even if they're mostly private, is
usually better than reserving them for implementations
# It shows that the {{MapOutput}} types are bound to the impl, e.g.,
{{InMemoryMapOutput}} calls {{closeInMemoryFile}} on the {{MergeManager}}
instance, which is only part of that impl's API.
This does the naive rename, and also renames the findbugs exclude rule for the
{{MergeManager}}. I'd be OK with the patch as-is, but would prefer this.
> Refactor MapOutput and MergeManager to facilitate reuse by Shuffle
> implementations
> ----------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4808
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4808
> Project: Hadoop Map/Reduce
> Issue Type: New Feature
> Reporter: Arun C Murthy
> Assignee: Mariappan Asokan
> Attachments: COMBO-mapreduce-4809-4812-4808.patch, M4808-0.patch,
> mapreduce-4808.patch, mapreduce-4808.patch, mapreduce-4808.patch,
> mapreduce-4808.patch, mapreduce-4808.patch, mapreduce-4808.patch,
> mapreduce-4808.patch, mapreduce-4808.patch, MergeManagerPlugin.pdf,
> MR-4808.patch
>
>
> Now that Shuffle is pluggable (MAPREDUCE-4049), it would be convenient for
> alternate implementations to be able to reuse portions of the default
> implementation.
> This would come with the strong caveat that these classes are LimitedPrivate
> and Unstable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
