[
https://issues.apache.org/jira/browse/MAPREDUCE-4822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13571122#comment-13571122
]
Hadoop QA commented on MAPREDUCE-4822:
--------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12567961/MAPREDUCE-4822.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3302//testReport/
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3302//console
This message is automatically generated.
> Unnecessary conversions in History Events
> -----------------------------------------
>
> Key: MAPREDUCE-4822
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4822
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: jobhistoryserver
> Affects Versions: 0.23.4
> Reporter: Robert Joseph Evans
> Assignee: Chu Tong
> Priority: Trivial
> Labels: patch
> Fix For: 0.24.0
>
> Attachments: MAPREDUCE-4822.patch
>
>
> There are a number of conversions in the Job History Event classes that are
> totally unnecessary. It appears that they were originally used to convert
> from the internal avro format, but now many of them do not pull the values
> from the avro they store them internally.
> For example:
> {code:title=TaskAttemptFinishedEvent.java}
> /** Get the task type */
> public TaskType getTaskType() {
> return TaskType.valueOf(taskType.toString());
> }
> {code}
> The code currently is taking an enum, converting it to a string and then
> asking the same enum to convert it back to an enum. If java work properly
> this should be a noop and a reference to the original taskType should be
> returned.
> There are several places that a string is having toString called on it, and
> since strings are immutable it returns a reference to itself.
> The various ids are not immutable and probably should not be changed at this
> point.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
