[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karthik Kambatla updated MAPREDUCE-4707:
----------------------------------------

    Status: Open  (was: Patch Available)
    
> Add a comment to explain why FairScheduler#dump()'s body is synchronized on 
> eventLog
> ------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4707
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4707
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: contrib/fair-share
>    Affects Versions: 1.0.3
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Trivial
>         Attachments: MR-4707.patch, MR-4707.patch
>
>
> FairScheduler#dump() is a synchronized method. In addition to that, the 
> entire method body is in a synchronized block on eventLog. However, there is 
> no other portion of the code that tries to acquire a lock on eventLog. So, it 
> seems like the second synchronized block is redundant, and can be removed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to