[ 
https://issues.apache.org/jira/browse/MAPREDUCE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

omkar vinit joshi updated MAPREDUCE-4330:
-----------------------------------------

    Attachment: MAPREDUCE-4330-21032013.patch

The patch fixed 2 issues
If the TaskAttemptCompletionEvent is fired twice for same job task attempt and 
1) if the first attempt is SUCCESSFUL and second attempt is anything other than 
SUCCESSFUL then earlier SUCCESSFUL attempt's state is changed to OBSOLETE.
2) if the first attempt is SUCCESSFUL and second attempt too is SUCCESSFUL then 
it marks the first attempt as OBSOLETE and updates the task's successful 
attempt to the second one.

                
> TaskAttemptCompletedEventTransition invalidates previously successful attempt 
> without checking if the newly completed attempt is successful
> -------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-4330
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-4330
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>            Reporter: Bikas Saha
>            Assignee: omkar vinit joshi
>         Attachments: MAPREDUCE-4330-21032013.patch
>
>
> The previously completed attempt is removed from 
> successAttemptCompletionEventNoMap and marked OBSOLETE.
> After that, if the newly completed attempt is successful then it is added to 
> the successAttemptCompletionEventNoMap. 
> This seems wrong because the newly completed attempt could be failed and thus 
> there is no need to invalidate the successful attempt.
> One error case would be when a speculative attempt completes with 
> killed/failed after the successful version has completed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to