[
https://issues.apache.org/jira/browse/MAPREDUCE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13609797#comment-13609797
]
Hadoop QA commented on MAPREDUCE-4330:
--------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12574935/MAPREDUCE-4330-21032013.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 tests included appear to have a timeout.{color}
{color:red}-1 javac{color}. The applied patch generated 1365 javac
compiler warnings (more than the trunk's current 1362 warnings).
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3453//testReport/
Javac warnings:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3453//artifact/trunk/patchprocess/diffJavacWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/3453//console
This message is automatically generated.
> TaskAttemptCompletedEventTransition invalidates previously successful attempt
> without checking if the newly completed attempt is successful
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4330
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4330
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Reporter: Bikas Saha
> Assignee: omkar vinit joshi
> Attachments: MAPREDUCE-4330-21032013.patch
>
>
> The previously completed attempt is removed from
> successAttemptCompletionEventNoMap and marked OBSOLETE.
> After that, if the newly completed attempt is successful then it is added to
> the successAttemptCompletionEventNoMap.
> This seems wrong because the newly completed attempt could be failed and thus
> there is no need to invalidate the successful attempt.
> One error case would be when a speculative attempt completes with
> killed/failed after the successful version has completed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
