[
https://issues.apache.org/jira/browse/MAPREDUCE-4330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613498#comment-13613498
]
Siddharth Seth edited comment on MAPREDUCE-4330 at 3/26/13 5:33 AM:
--------------------------------------------------------------------
Omkar, the code change to JobImpl itself looks good.
The unit test needs some changes though, mostly minor.
- Don't think the CommitterEventHandler really needs to be setup.
- A mockito mock of TaskImpl will likely be simpler.
Patch needs formatting fixes.
was (Author: sseth):
Omkar, the code change to JobImpl itself looks good.
The unit test needs some changes though
-
> TaskAttemptCompletedEventTransition invalidates previously successful attempt
> without checking if the newly completed attempt is successful
> -------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-4330
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4330
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.23.1
> Reporter: Bikas Saha
> Assignee: omkar vinit joshi
> Attachments: MAPREDUCE-4330-21032013.1.patch,
> MAPREDUCE-4330-21032013.patch
>
>
> The previously completed attempt is removed from
> successAttemptCompletionEventNoMap and marked OBSOLETE.
> After that, if the newly completed attempt is successful then it is added to
> the successAttemptCompletionEventNoMap.
> This seems wrong because the newly completed attempt could be failed and thus
> there is no need to invalidate the successful attempt.
> One error case would be when a speculative attempt completes with
> killed/failed after the successful version has completed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
