[
https://issues.apache.org/jira/browse/MAPREDUCE-4974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619455#comment-13619455
]
Robert Joseph Evans edited comment on MAPREDUCE-4974 at 4/2/13 2:22 AM:
------------------------------------------------------------------------
I pulled the patch out. Sorry Gera I did not see the review board comments. I
will try to be more complete next time. All of the other times that I have used
review board the comments were posted to the JIRA, but I guess that is not the
case any more. Either way it is my fault.
The test that caught this too is TestMRKeyValueTextInputFormat.
was (Author: revans2):
I pulled the patch out. Sorry [~gera] I did not see the review board
comments. I will try to be more complete next time. All of the other times
that I have used review board the comments were posted to the JIRA, but I guess
that is not the case any more. Either way it is my fault.
The test that caught this too is TestMRKeyValueTextInputFormat.
> Optimising the LineRecordReader initialize() method
> ---------------------------------------------------
>
> Key: MAPREDUCE-4974
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4974
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv1, mrv2, performance
> Affects Versions: 2.0.2-alpha, 0.23.5
> Environment: Hadoop Linux
> Reporter: Arun A K
> Assignee: Gelesh
> Labels: patch, performance
> Fix For: 0.23.7, 2.0.5-beta
>
> Attachments: MAPREDUCE-4974.2.patch, MAPREDUCE-4974.3.patch,
> MAPREDUCE-4974.4.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> I found there is a a scope of optimizing the code, over initialize() if we
> have compressionCodecs & codec instantiated only if its a compressed input.
> Mean while Gelesh George Omathil, added if we could avoid the null check of
> key & value. This would time save, since for every next key value generation,
> null check is done. The intention being to instantiate only once and avoid
> NPE as well. Hope both could be met if initialize key & value over
> initialize() method. We both have worked on it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
