[ 
https://issues.apache.org/jira/browse/MAPREDUCE-5161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13635841#comment-13635841
 ] 

Bikas Saha commented on MAPREDUCE-5161:
---------------------------------------

Then I dont understand why some diff show up? e.g. 
>From the diff in your comment above
{code}
         FileSystem fs = paths[i].getFileSystem(job);
-        Path p = new Path(paths[i].toUri().getPath());
+        Path p = new Path(paths[i].toString());
         if (onepool.accept(p)) {
{code}

>From the attached patch.
{code}
         FileSystem fs = paths[i].getFileSystem(job);
-        Path p = new Path(paths[i].toUri().getPath());
+        Path p = fs.makeQualified(paths[i]);
         if (onepool.accept(p)) {
{code}

Shouldnt I see?
{code}
         FileSystem fs = paths[i].getFileSystem(job);
-        Path p = new Path(paths[i].toString());
+        Path p = fs.makeQualified(paths[i]);
         if (onepool.accept(p)) {
{code}

                
> CombineFileInputFormat fix for paths not on default FS merge from branch-1 to 
> branch-1-win
> ------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-5161
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-5161
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: mrv1
>    Affects Versions: 1-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: MAPREDUCE-5161-branch-1-win.1.patch
>
>
> MAPREDUCE-1806 fixed a bug related to use of {{CombineFileInputFormat}} with 
> paths that are not on the default file system.  This same bug was fixed 
> independently on branch-1-win.  The code was slightly different, but 
> equivalent to the branch-1 fix.  This jira will apply the branch-1 fix to 
> branch-1-win to keep the 2 code lines in agreement.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to