[
https://issues.apache.org/jira/browse/MAPREDUCE-5069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13639923#comment-13639923
]
Sangjin Lee commented on MAPREDUCE-5069:
----------------------------------------
Thanks Robert for detailed feedback! I greatly appreciate it.
We went back and forth on the name. Initially I named it RecordReaderWrapper,
but it wasn't clear that it should be used in the context of
CombineFileRecordReader, so CombineFileRecordReaderWrapper was suggested. As
you said, I'm also not sure what might be a better name without being too
verbose. I'm not married to the current name, but I'm slightly inclined to
leaving it as is.
As for the second point, I agree that the chance of this condition being
violated is remote. I'm going to turn this into an assert.
I also hear you about the random seeds. The only reason I used them that way is
frankly I followed the precedent of other similar tests. I hope it's
acceptable...
I'll submit a new version of the patch soon. Thanks again!
> add concrete common implementations of CombineFileInputFormat
> -------------------------------------------------------------
>
> Key: MAPREDUCE-5069
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-5069
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: mrv1, mrv2
> Affects Versions: 2.0.3-alpha
> Reporter: Sangjin Lee
> Priority: Minor
> Attachments: MAPREDUCE-5069-1.patch, MAPREDUCE-5069-2.patch,
> MAPREDUCE-5069-3.patch, MAPREDUCE-5069-4.patch, MAPREDUCE-5069-5.patch,
> MAPREDUCE-5069.patch
>
>
> CombineFileInputFormat is abstract, and its specific equivalents to
> TextInputFormat, SequenceFileInputFormat, etc. are currently not in the
> hadoop code base.
> These sound like very common need wherever CombineFileInputFormat is used,
> and different folks would write the same code over and over to achieve the
> same goal. It sounds very natural for hadoop to provide at least the text and
> sequence file implementations of the CombineFileInputFormat class.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
